Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic optimization example unknown arguments issues #329

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

IanBoyanZhang
Copy link
Contributor

@IanBoyanZhang IanBoyanZhang commented Apr 18, 2019

Description

Remove verbose and print_step arguments when calling GlobalBestPSO optimizer in multiple examples and docs.

Related Issue

Fixing outdated examples and documents issues reported in issue 264 and in issue 317.

Motivation and Context

Thank you for providing great open source project.

Was trying to run inverse kinematics example and basic optimization example jupyter notebook. Original examples complain unexpected keyword argument errors for verbose and print_step.

I haven't gone through the solver source code, hopefully this is the right fix that is inline with author's intention.

How Has This Been Tested?

Ran basic_optimization jupyter notebook locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ljvmiranda921 ljvmiranda921 self-assigned this Apr 25, 2019
@ljvmiranda921 ljvmiranda921 added the documentation Documentation improvements or fixes label Apr 25, 2019
@ljvmiranda921
Copy link
Owner

LGTM! Thank you for your contribution @IanBoyanZhang !

@ljvmiranda921 ljvmiranda921 merged commit 90275e6 into ljvmiranda921:master Apr 25, 2019
@ljvmiranda921
Copy link
Owner

@allcontributors[bot] please add @IanBoyanZhang for docs and examples

@allcontributors
Copy link
Contributor

@ljvmiranda921

I've put up a pull request to add @IanBoyanZhang! 🎉

@bhaskatripathi
Copy link

bhaskatripathi commented May 18, 2019

Your BinaryPSO with the objective function mentioned in the documentation doesn't works. It returns an n-dimensional array instead of [1 0 0 01 01...etc]
Please correct get that fixed too as it is better to not give examples of running code than giving incorrect/outdated ones

@ljvmiranda921
Copy link
Owner

HI @bhaskatripathi , can you point the specific part of the documentation where it does not work? I've already tested what's working on this link and it gives the correct output as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants