Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote function was severely broken:
operators were quoted; should have been output literally
backslashes were used as escapes inside single-quoted strings (they lose the escape meaning inside single quoted strings)
Ugliness - when no quoting was needed, it was applied anyway examples:
Fixes Mergesium#1 and #11
Merge Conflict Note: This branch is based on v1.0.0 from substack's repo, meaning other forks in substack's network can merge it cleanly. Due to the refactor at 553fdfc there is now a merge conflict (Originally the quote functions were in
index.js
, at 553fdfc they were moved toquote.js
). To resolve the merge conflict onto the refactored lib, you can use thequote.js
file from 6e9606b, although it also contains the Unicode/unprintables escaping functionality andquote_ascii()
, which are part of my 2.0.0 release, as well as the various fixes from substack's fork network that I was able to find. See CHANGELOG.md at Mergesium@6e9606b#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed for summary. I'll be happy to answer questions.Author-Rebase-Consent: https://No-rebase.github.io