Use fs.realpathSync in resolved files to support linked packages #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
master
branch
6 times, most recently
from
690f55f to
26369cf
Compare
|
Should this PR be in https://github.com/substack/node-resolve instead of https://github.com/ljharb/node-resolve? |
|
@apaatsio it should be there but substack has blocked my profile on GitHub and my account can't create a PR for repos he owns. I've made PRs for some nasty bugs I ran into with tape and I wasn't too nice about it over IRC. |
|
i still haven't had time to integrate this into the main repo, altho i've just rebased and updated this PR. |
ljharb
force-pushed
the
master
branch
3 times, most recently
from
002814b to
703517b
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
1b23d85 to
88c0778
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
84f62ad to
cfd0bb8
Compare
ljharb
force-pushed
the
master
branch
7 times, most recently
from
cfcbda3 to
04e6c79
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
e0e79a6 to
4acd1f3
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
2418ae6 to
e9842fc
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
782fa69 to
0953f42
Compare
|
@L8D i know it's been awhile, but I've rebased this, and there's a bunch of relevant tests failing (ignore the windows ones). Can you try to get them passing? |
ljharb
force-pushed
the
main
branch
2 times, most recently
from
8ac98da to
28e3de8
Compare
ljharb
force-pushed
the
main
branch
7 times, most recently
from
ce6ce25 to
6c3d87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.