[Fix] jsx-indent: properly report on returned ternaries with jsx

Fixes jsx-eslint#3222
ljharb · Feb 25, 2022 · 625010a · 625010a
1 parent a8fca2a
commit 625010a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 ### Fixed
 * [`jsx-curly-brace-presence`]: avoid warning on curlies containing quote characters ([#3214][] @ljharb)
 * [`jsx-indent`]: do not report on non-jsx-returning ternaries that contain null ([#3222][] @ljharb)
+* [`jsx-indent`]: properly report on returned ternaries with jsx ([#3222][] @ljharb)
 
 [#3222]: https://github.com/yannickcr/eslint-plugin-react/issues/3222
 [#3214]: https://github.com/yannickcr/eslint-plugin-react/issues/3214

diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -415,7 +415,10 @@ module.exports = {
       JSXText: handleLiteral,
 
       ReturnStatement(node) {
-        if (!node.parent) {
+        if (
+          !node.parent
+          || !jsxUtil.isJSX(node.argument)
+        ) {
           return;
         }
 

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -1219,6 +1219,16 @@ const Component = () => (
       `,
       options: [99],
     },
+    {
+      code: `
+        function test (foo) {
+          return foo != null
+            ? <div>foo</div>
+            : <div>bar</div>
+        }
+      `,
+      options: [2],
+    },
   ]),
 
   invalid: parsers.all([].concat(