Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passkey autofill #59

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Add passkey autofill #59

merged 6 commits into from
Dec 2, 2023

Conversation

danielgpinheiro
Copy link
Contributor

@danielgpinheiro danielgpinheiro commented Oct 13, 2023 •
edited
Loading

Overview

Added Passkey autofill on browsers its supports
Resolves #57

Changes

  • Added checkConditionalUIAvailable on authentication_hook to enable passkey autofill
  • Add AbortController Class to abort navigation.crendentials.get
  • Add browserSupportsPasskeyAutofill helper

Tests

I used my personal project with this changes and successfully autofill passkey on Safari/iOS and Chrome/Mac, also inputing email on input works just fine, like before.
My personal project

Collaborators

  1. @danielgpinheiro

@danielgpinheiro danielgpinheiro marked this pull request as draft October 13, 2023 15:24
@danielgpinheiro danielgpinheiro marked this pull request as ready for review October 13, 2023 15:25
@danielgpinheiro danielgpinheiro mentioned this pull request Oct 13, 2023
Closed
@type1fool type1fool added the enhancement New feature or request label Oct 13, 2023
type1fool
type1fool approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@type1fool type1fool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I tested this in an application, and I was prompted to use an existing Passkey, which successfully authenticated my user account.

Thank you! 💾

@type1fool type1fool merged commit de2f439 into liveshowy:main Dec 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@type1fool type1fool type1fool approved these changes

Assignees

@danielgpinheiro danielgpinheiro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] - Passkeys input autofill (Conditional UI)
2 participants
@danielgpinheiro @type1fool