cmd, eth, server, pm: Streamflow client compatibility#1114
cmd, eth, server, pm: Streamflow client compatibility#1114kyriediculous merged 8 commits intomasterfrom
Conversation
|
4f0febe refactors the subscription mechanism for This adds two fields to the
Subscriptions created and tracked through
The sink channel is of type |
|
Fixed a small issue whereby the test harness would panic when calling If |
yondonfu
left a comment
There was a problem hiding this comment.
Changes look good. Let's rebase!
…wardCut references
…scoderPoolMaxSize
…ogic, withdrawRound instead of withdrawBlock
583a3b5 to
ebdaed8
Compare
|
rebase done ! |
|
Can you please delete this closed branch? |
What does this pull request do? Explain your changes. (required)
This PR addresses some of the compatibility issues the current go-livepeer client has with the new.
protocol/streamflowbranch after regenerating the contract bindings.For a detailed list of the updates see specific upgrades
Specific updates (required)
e397e0c: Regenerate the contract bindings using
abigen. Created a wrapper arround the TicketBroker session becauseabigendoes not generate client side structs for all contract types. abigen: Does not include all structs in binding ethereum/go-ethereum#201483184658: Removes any reference to/usage of
pricePerSegment,pendingRewardCutandpendingFeeShareand update the CLI implementation and user facing language.63fab12: Removes the usage of
NumActiveTranscodersas the generated function from thepublicvariablenumActiveTranscoderson the contracts is now deprecated. Instead we'll useGetTranscoderPoolMaxSize.7174eb1: update
isActiveTranscoderusage to reflect its implementation on theprotocol/streamflowbranch, meaning it doesn't take a secondroundargument anymore. InsteadIsActiveTranscoderwill return the active status for a transcoder for the current round34d7c28: Change the definition of
pm.SenderInfoto removeReserveStateandThawRoundreferences34d7c28: Change the definition of
pm.SenderInfoto useWithdrawRoundinstead ofWithdrawBlock34d7c28: Change the definition of
pm.SenderInfoto use a newpm.ReserveInfotype instead of aSenderInfo.Reserve *big.Inttype.pm.ReserveInfoholdsReserveInfo.FundsRemainingandReserveInfo.ClaimedInCurrentRoundfrom which a sender's total available reserve for a round is calculated by adding these two values.2c9e40f: Adds a dependency to the
RoundsWatchertoSenderWatcherthrough anEventWatcherinterface which exposes a singleSubscribemethod. This allows theSenderWatcherto describe toNewRoundevents. This is needed because since removingReserveState, amounts claimed from a reserve are reset on a per-round basis rather than when thereserveNonceincreases due to funding a thawed reserve.c82f82d Removes
LivepeerVerifierreferences in theethpackage since Streamflow will not contain on-chain verification components in it's initial release. The contract itself has also been deleted in the Streamflow branch for the protocol repo.TODO: Look into the subscription mechanism used for the blockwatch package.
How did you test each of these updates (required)
Adjusted & ran unit tests
Does this pull request close any open issues?
Fixes #1089
Fixes #1090
Checklist:
./test.shpass