Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log failed call transfers as warnings. #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log failed call transfers as warnings. #244

wants to merge 1 commit into from

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Dec 11, 2024

No description provided.

@dennwc dennwc self-assigned this Dec 11, 2024
@dennwc dennwc requested a review from a team as a code owner December 11, 2024 12:12
biglittlebigben
biglittlebigben reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@biglittlebigben biglittlebigben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will log a waring every case the transferred to number doesn't pick up, for instance. What is the motivation?

@dennwc
Copy link
Contributor Author

dennwc commented Dec 12, 2024

I need at least some indication that transfer failed in an unexpected way. Will add a SIP status code check before logging to warning, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biglittlebigben biglittlebigben biglittlebigben left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@dennwc dennwc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennwc @biglittlebigben