Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): initial impl #616

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(rpc): initial impl #616

wants to merge 5 commits into from
+842 −7

Conversation

anunaym14
Copy link

@anunaym14 anunaym14 commented Feb 20, 2025 •
edited
Loading

TODO:
- documentation/comments Done
- default timeout value Done

  • add tests?

bcherry
bcherry reviewed Feb 20, 2025
View reviewed changes
Copy link

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks exactly correct, nice work! I'll let someone else comment on the actual go implementation.

@livekit livekit deleted a comment from bcherry Feb 20, 2025
@livekit livekit deleted a comment from bcherry Feb 20, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

paulwe
paulwe reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@paulwe paulwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add some tests? maybe check that success/timeout work correctly?

@anunaym14
Copy link
Author

anunaym14 commented Feb 21, 2025 •
edited
Loading

@bcherry we don't check if someone tries to create a new RpcError with a built-in code, should that be handled?

If not, exposing the method for using builtIn codes to create an RpcError could be useful.

paulwe
paulwe approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@paulwe paulwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@anunaym14
Copy link
Author

Thanks @paulwe, will merge this after adding some tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherry bcherry bcherry left review comments

@paulwe paulwe paulwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anunaym14 @CLAassistant @bcherry @paulwe