Skip to content

Conversation

@cloudwebrtc
Copy link
Contributor

The room is unable to emit mute/unmute events. This is because publication.set_track for local tracks was not called to register event handlers, and there is another minor bug.

@cloudwebrtc cloudwebrtc mentioned this pull request Dec 1, 2025
Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

"name": "wgpu_room(debug)",
"program": "${workspaceFolder}/examples/target/debug/wgpu_room",
"preLaunchTask": "build"
},
Copy link
Contributor

@ladvoc ladvoc Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, but do you think we should commit this launch configuration?

@cloudwebrtc cloudwebrtc merged commit 8b39d03 into main Dec 2, 2025
20 checks passed
@cloudwebrtc cloudwebrtc deleted the duan/fix-mute-unmute-events-for-local-track branch December 2, 2025 05:57
@github-actions github-actions bot mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants