fix some potential audio issues, clean up the code a bit, and suppress some warnings #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes on the C++ code:
Suppressing some compilation warnings:
66 | fn utf8_aware_chunks(&self, chunk_size: usize) -> Utf8AwareChunks {
| ^^^^^ --------------- the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use
'_for type paths|
66 | fn utf8_aware_chunks(&self, chunk_size: usize) -> Utf8AwareChunks<'_> {
| ++++
warning: hiding a lifetime that's elided elsewhere is confusing
and one webrtc related nullable warning