fix: do not log 'signal client closed: "stream closed"' on disconnect #727
Conversation
when server sends an explicit LeaveRequest, we would still end up logging ``` livekit::rtc_engine:453:livekit::rtc_engine - received session close: "signal client closed: \"stream closed\"" UnknownReason Resume ``` that's due to the signal client being closed after an explicit Leave is sent
|
Actually, I just realized this change might have broken |
|
oh that's not good. how does the test tear down signal connection? |
|
The test calls |
livekit/src/rtc_engine/mod.rs
Outdated
| match action { | ||
| proto::leave_request::Action::Resume | ||
| | proto::leave_request::Action::Reconnect => { | ||
| let running_handle = self.running_handle.read(); |
There was a problem hiding this comment.
It appears reading from the RwLock on this line leads to a deadlock—I will have to dig deeper to determine why this is the case.
There was a problem hiding this comment.
I see the issue, the read lock wasn't released in time. fixed in 701962c
when server sends an explicit LeaveRequest, we would still end up logging
that's due to the signal client being closed after an explicit Leave is sent