Skip to content

Conversation

@s-hamdananwar
Copy link
Contributor

Participant SID and Identity were being set as empty since .then_some(user.participant_sid) would return None when original fields has some value (ie. not none)

@s-hamdananwar
Copy link
Contributor Author

@chenosaurus are the build errors safe to be ignored?

@chenosaurus
Copy link
Contributor

@chenosaurus are the build errors safe to be ignored?

hmm, I thought those got fixed. @ladvoc do you know?

Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@ladvoc
Copy link
Contributor

ladvoc commented Sep 18, 2025

I also thought these build issues were fixed, but it looks like they are not related to this PR.

@s-hamdananwar s-hamdananwar merged commit 8bcbf55 into main Sep 18, 2025
13 of 19 checks passed
@s-hamdananwar s-hamdananwar deleted the hamdan/fix-data-message-empty-participant branch September 18, 2025 21:13
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants