Move RPC handlers to room #599
Conversation
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
| } | ||
| } | ||
|
|
||
| pub fn register_rpc_method( |
There was a problem hiding this comment.
can we keep deprecated stubs of these around that just forward to the new room method? that way its not a breaking change
There was a problem hiding this comment.
@bcherry
Oh, I was thinking of covering this on the foreign language side.
I didn’t want to support the old interface from rust side, since that would mean we’d have to keep the old proto definitions around and start adding things like RegisterRpcMethodRequest2, which I’d rather avoid. What do you think?
There was a problem hiding this comment.
i don't think you need to expose the old interface over FFI (agree you can just handle it in python/node), but the underlying rust rtc sdk would ideally still offer it. i don't think there'd be extra proto definitions around in that case
There was a problem hiding this comment.
I see — you mean keeping the old interface on the livekit crate, not in livekit-ffi. That makes sense to me. Will do!
No description provided.