Refactor shared lib to use fs.FS
#706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Oct 17, 2025
rektdeckard
approved these changes
Oct 17, 2025
Member
rektdeckard
left a comment
rektdeckard
left a comment
There was a problem hiding this comment.
Nice, thanks for the change!
Comment on lines
-184
to
-217
| // Follow symlinks and include the actual file contents | ||
| if info.Mode()&os.ModeSymlink != 0 { | ||
| realPath, err := filepath.EvalSymlinks(path) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to evaluate symlink %s: %w", path, err) | ||
| } | ||
| info, err = os.Stat(realPath) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to stat %s: %w", realPath, err) | ||
| } | ||
| // Open the real file instead of the symlink | ||
| file, err := os.Open(realPath) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to open file %s: %w", realPath, err) | ||
| } | ||
| defer file.Close() | ||
|
|
||
| header, err := tar.FileInfoHeader(info, "") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create tar header for file %s: %w", path, err) | ||
| } | ||
| header.Name = relPath | ||
| if err := tarWriter.WriteHeader(header); err != nil { | ||
| return fmt.Errorf("failed to write tar header for file %s: %w", path, err) | ||
| } | ||
|
|
||
| // Copy file contents directly without progress bar | ||
| _, err = io.Copy(tarWriter, file) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to copy file content for %s: %w", path, err) | ||
| } | ||
| return nil | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think there was at least one user who needed symlinking to support a monorepo with multiple agent projects and shared code...but I guess until we have a better solution for that use-case it is okay to remove this.
Contributor
Author
There was a problem hiding this comment.
Yeah hopefully in those cases, the original files are part of the source so this won't be an issue.
Member
There was a problem hiding this comment.
They had shared code and each agent at the same level, so they would have to make some changes. They were doing this:
/shared
/agent-a
agent.py
pyptoject.toml
/agent-b
agent.py
pyptoject.toml
But still think its okay to break. Let's do a minor version bump when we release this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor shared lib to use
fs.FSinstead ofworkingDirto support both real and virtual file systems.Unlike previous behavior, all symlink files are excluded.
ref HA-304