Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leaked renderers appeared on camera switch #507

Merged
merged 3 commits into from
Oct 27, 2024
+8 −1
Merged

Remove leaked renderers appeared on camera switch #507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3d81e0
Remove leaked renderers appeared on camera switch
VatamanuBogdan Oct 25, 2024
ef463d5
Merge branch 'main' into fix-renderer-leaks
VatamanuBogdan Oct 25, 2024
76e3500
Merge branch 'main' into fix-renderer-leaks
hiroshihorie Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sources/LiveKit/Views/VideoView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,17 +705,24 @@ extension VideoView: VideoRenderer {
}
self._secondaryRenderer = nil
}

let previousPrimaryRendered = self._primaryRenderer
let completion: (Bool) -> Void = { _ in
previousPrimaryRendered?.removeFromSuperview()
}

// Currently only for iOS
#if os(iOS)
let (mode, duration, position) = _state.read { ($0.transitionMode, $0.transitionDuration, $0.captureDevice?.facingPosition) }
if let transitionOption = mode.toAnimationOption(fromPosition: position) {
UIView.transition(with: self, duration: duration, options: transitionOption, animations: block, completion: nil)
UIView.transition(with: self, duration: duration, options: transitionOption, animations: block, completion: completion)
} else {
block()
completion(true)
}
#else
block()
completion(true)
#endif
}
}
Expand Down
Loading