-
Notifications
You must be signed in to change notification settings - Fork 127
AudioManager adjustments #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think @davidzhao 's idea to offer a pinned category is a good alternative. basically instead of worth considering and maybe more future-proof? |
maybe we can allow pinning a |
Yeah that's also a better way to expose a lot of detailed configuration capability, without the customConfigureFunc which is pretty messy to actually use. |
So a pinned configuration for all states ? or per state ? |
IMO just a single state.. users could change it however they want.. but most likely my guess is they would stay in a single configuration. for those that want dynamic configuration, they could already implement the function override. |
.playAndRecord
@@ -121,6 +123,12 @@ public class AudioManager: Loggable { | |||
set { _state.mutate { $0.isSpeakerOutputPreferred = newValue } } | |||
} | |||
|
|||
/// If this is set, this will be used instead of dynamic configuration. | |||
public var sessionConfiguration: AudioSessionConfiguration? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add a comment to the customConfigureFunc as well noting that if you set it then the sessionConfiguration and isSpeakerOutputPreferred properties will be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me - great change
No description provided.