Local track subscribed event #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherry
approved these changes
Aug 26, 2024
cloudwebrtc
approved these changes
Aug 27, 2024
hiroshihorie
commented
Aug 27, 2024
| @@ -79,6 +79,10 @@ public protocol ParticipantDelegate: AnyObject { | |||
| @objc(localParticipant:didUnpublishTrack:) optional | |||
| func participant(_ participant: LocalParticipant, didUnpublishTrack publication: LocalTrackPublication) | |||
|
|
|||
| /// Fired when the first remote participant has subscribed to the localParticipant's track. | |||
| @objc(localParticipant:didSubscribeTrack:) optional | |||
| func participant(_ participant: LocalParticipant, didSubscribeTrack publication: LocalTrackPublication) | |||
There was a problem hiding this comment.
This name sounds like the local participant subscribed to the track, wonder if i can put a better name for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fired when the first remote participant has subscribed to the localParticipant's track.