Relaunch screenshare ext. when re-enabling the track #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshihorie
requested review from
davidzhao,
cloudwebrtc and
davidliu
and removed request for
cloudwebrtc
|
On the other platforms, the screenshare track is unpublished entirely on disable, maybe we should do that to align the behavior? |
|
Either way would work but I should also align MacOS screen capturing also in that case. |
|
I think i'll just unpublish it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless unpublished, the screenshare ext was not re-launching when calling setScreenShare(enabled: true) in iOS causing confusion.
Related issues:
#412
livekit-examples/swift-example#37
livekit-examples/swift-example#39