Simplify code by merging Room and Engine #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit e4f7d66 Author: Hiroshi Horie <[email protected]> Date: Sat Jun 15 00:22:21 2024 +0900 Use new internal import instead of `@_implementationOnly` (#402) This is giving compile time warnings. Use `Access-level modifiers on import declarations` instead of `@_implementationOnly`. Spec: https://github.com/apple/swift-evolution/blob/main/proposals/0409-access-level-on-imports.md Swift 5.9+ commit b9354ab Author: Hiroshi Horie <[email protected]> Date: Sat Jun 15 00:07:38 2024 +0900 Use WebRTC M125 (#403)
hiroshihorie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify internal code by merging separate Room and Engine objects.