Skip to content

Register online listener in engine's join #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 2 commits into from
Sep 23, 2025
Merged

Register online listener in engine's join #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fef5e
Register online listener in engine's join
lukasIO Sep 22, 2025
ad26c58
Create many-stingrays-joke.md
lukasIO Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-stingrays-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Register online listener in engine's join
2 changes: 1 addition & 1 deletion src/room/RTCEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
this.client = new SignalClient(undefined, this.loggerOptions);
this.client.signalLatency = this.options.expSignalLatency;
this.reconnectPolicy = this.options.reconnectPolicy;
this.registerOnLineListener();
this.closingLock = new Mutex();
this.dataProcessLock = new Mutex();
this.dcBufferStatus = new Map([
Expand Down Expand Up @@ -271,6 +270,7 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
this.negotiate();
}

this.registerOnLineListener();
this.clientConfiguration = joinResponse.clientConfiguration;
this.emit(EngineEvent.SignalConnected, joinResponse);
return joinResponse;
Expand Down
Loading