move the accessToken to header #891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hiroshihorie, do we have any setups for the flutter format ? like using a script or some setups on Android Studio ? |
|
flutter analyze gives me the same errors on main, I put in some lines of code in analysis_options.yaml to suppress the warnings instead. |
|
Hi @hiroshihorie @cloudwebrtc , could you please help review this PR? |
|
@xianshijing-lk You just need to run |
hiroshihorie
approved these changes
Oct 18, 2025
| use_super_parameters: ignore | ||
| avoid_print: ignore | ||
| use_build_context_synchronously: ignore | ||
| discarded_futures: ignore |
There was a problem hiding this comment.
discarded_futures are something we should fix soon for safer code, but it's fine to suppress it temporary if we don't forget about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the access_token to header in the format of 'Authorization': 'Bearer $token'