Skip to content

clamp the response timeout to at least 1s #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

clamp the response timeout to at least 1s #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/participant/LocalParticipant.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,9 @@ internal constructor(
// Maximum amount of time it should ever take for an RPC request to reach the destination, and the ACK to come back
// This is set to 7 seconds to account for various relay timeouts and retries in LiveKit Cloud that occur in rare cases
val maxRoundTripLatency = 7.seconds
// Minimum allowed effective timeout to ensure the RPC lifecycle always has at least
// one second to complete, even after accounting for round-trip latency.
val minEffectiveTimeout = 1.seconds

if (payload.byteLength() > RTCEngine.MAX_DATA_PACKET_SIZE) {
throw RpcError.BuiltinRpcError.REQUEST_PAYLOAD_TOO_LARGE.create()
Expand All @@ -1111,13 +1114,14 @@ internal constructor(
}

val requestId = UUID.randomUUID().toString()

// Ensure the effective response timeout is not less than 1 second
val effectiveTimeout = (responseTimeout - maxRoundTripLatency).coerceAtLeast(minEffectiveTimeout)
val result = publishRpcRequest(
destinationIdentity = destinationIdentity,
requestId = requestId,
method = method,
payload = payload,
responseTimeout = responseTimeout - maxRoundTripLatency,
responseTimeout = effectiveTimeout,
)

if (result.isFailure) {
Expand Down
2 changes: 2 additions & 0 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/rpc/RpcManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ interface RpcManager {
* @param method The method name to call.
* @param payload The payload to pass to the method.
* @param responseTimeout Timeout for receiving a response after initial connection.
* If a value less than 8s is provided, it will be automatically clamped to 8s
* to ensure sufficient time for round-trip latency buffering.
* Defaults to 15 seconds.
* @return The response payload.
* @throws RpcError on failure. Details in [RpcError.message].
Expand Down