Fix simulcast factory not sending back EncoderInfo #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidliu
commented
Mar 23, 2022
| } | ||
|
|
||
| override fun getEncoderInfo(): VideoEncoder.EncoderInfo { | ||
| val future = executor.submit(Callable { return@Callable encoder.encoderInfo }) |
There was a problem hiding this comment.
This is the main thing that was breaking the hardware encoder from working (and preventing H264 from working). EncoderInfo holds onto information needed for resolution alignment, which is used to adjust the resolution (only works on 16x16 aligned frames).
hiroshihorie
approved these changes
Mar 23, 2022
|
would flutter have the same issue then? |
|
Yeah, H264 works properly now. Flutter uses the same code IIRC, I'll put in a PR for Flutter tomorrow. It looks like this behavior got broken in the M97 upgrade, so the device farm testing will hopefully help catch these breakages down the road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.