fix: exclude temperature parameter for gpt-5 and similar models #3573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where certain models (like
gpt-5) should not receive atemperatureparameter.Previously,
temperature=0.0was always passed inextra_kwargs, which caused problems for models that do not accept this argument.Changes
excluded_models_temperaturelist (currently includesgpt-5).extra_kwargslogic to skip addingtemperatureif the model contains any excluded model name as substring.Before
After
Test Cases
Before Fix:
After Fix:
Issue Reference
Fixes: #3556
Notes
More models can be added to excluded_models_temperature in the future if needed.
This change ensures compatibility with gpt-5 while maintaining the original behavior for other models.