Google LLM plugin: Support passing credentials to the constructor #3533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mokeko
changed the title
mokeko
changed the title
|
Hi 👋 Just checking in — if there’s any feedback needed on this PR (or any change required), I’d be happy to make it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2701.
Other classes in Google plugins such as TTS and STT already accept explicit credentials, but LLM did not.
This PR adds support for passing credentials to the LLM plugin as well.
Notes on the implementation approach:
For example, in
sst.py, SpeechAsyncClient.from_service_account_info is used, which internally calls Credentials.from_service_account_info.Since
genai.Clientdoes not provide such a factory method, I decided to callCredentials.from_service_account_infomanually.