-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(speechmatics): add max_speakers parameter for speaker diarization #3524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidzhao
merged 8 commits into
livekit:main
from
nsepehr:feat/speechmatics-max-speakers
Oct 12, 2025
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8400a67
feat(speechmatics): add max_speakers parameter for speaker diarization
nsepehr 04ae148
Update livekit-plugins/livekit-plugins-speechmatics/livekit/plugins/s…
nsepehr 4b66311
Merge branch 'main' into feat/speechmatics-max-speakers
nsepehr f0497f5
refactor: use TranscriptionConfig constructor instead of mutation
nsepehr 9d2bedd
fix: address PR review comments and type checking errors
nsepehr fa814f6
Apply type checking fixes from PR #3599
nsepehr ee299b6
Fix additional_vocab to use list format as expected by API
nsepehr 8d894aa
feat: use dict for speaker diarization config to support speakers field
nsepehr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
livekit-plugins/livekit-plugins-speechmatics/livekit/plugins/speechmatics/utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use the dict for now with a
type: ignoreto ignore the type check?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SpeakerDiarizationConfig IS a dataclass provided by the Speechmatics SDK. We're using it correctly here. Whether you pass the dataclass or a dict, they serialize to the same JSON structure. The dataclass approach is cleaner and type-safe. I don't think we should change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the support of
speakersoptions using dict for now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... updated it with using dict. Can you review now please.