Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker, fill out CLI, + various lints #4

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add worker, fill out CLI, + various lints #4

merged 2 commits into from
Apr 12, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Apr 12, 2024

it compiles! and it seemingly connects to the server just fine.
however, my tests are only at the worker level (e.g. connects, sends heartbeats, exits okay)
i don't know how to test any real-world functionality without the plugins, despite the fact that i'm 100% sure that every sub-component does not work as expected (since i never tested any)

request for comments, tests, nits, lints, etc

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 🚀

It'd be great to add some CI test coverage.

agents/src/worker.ts Outdated Show resolved Hide resolved
@nbsp
Copy link
Member Author

nbsp commented Apr 12, 2024

It'd be great to add some CI test coverage.

how should we set up a test/coverage suite for this? should we run it against a (local? cloud?) livekit-server or mock the interface? mocking sounds more reasonable but the agents protocol is pretty vast and it'd take a while to map everything.

without plugins it's all quite abstract, i don't know what i'd write tests for exactly

@davidzhao
Copy link
Member

It'd be great to add some CI test coverage.

how should we set up a test/coverage suite for this? should we run it against a (local? cloud?) livekit-server or mock the interface? mocking sounds more reasonable but the agents protocol is pretty vast and it'd take a while to map everything.

without plugins it's all quite abstract, i don't know what i'd write tests for exactly

Right.. let's discuss this later. I was thinking it could test job lifecycle against livekit OSS, but honestly I'm not sure if it belongs in this repo. For our other repos we have been including unit/integration tests within the repo, and end to end testing (including LK server/etc) in a separate repo. Let's merge as is and discuss later!

@nbsp nbsp merged commit 2af7327 into main Apr 12, 2024
@nbsp nbsp deleted the nbsp/rfc branch April 12, 2024 06:23
@nbsp
Copy link
Member Author

nbsp commented Apr 12, 2024

note to self to save me some looking up later: Bun has built-in Jest-compatible test and coverage functionality via bun test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants