Update token endpoint response to match working standard #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meant that passing a custom body to /createToken did nothing!
- Make request / response body snake_case not camelCase - Add `participant_identity` / `participant_metadata` / `participant_attributes` / `room_config` request fields - Add `server_url` to token generation response
1egoman
commented
Sep 16, 2025
Comment on lines
57
to
59
| const app = express(); | ||
| app.use(bodyParser.json()); | ||
| const port = 3000; |
Contributor
Author
There was a problem hiding this comment.
As a FYI, there wasn't a body parser loaded in this example, so when I went to test my changes (even with the right Content-Type header), the custom request fields weren't being loaded since req.body was not being set. This should fix that!
bcherry
reviewed
Sep 16, 2025
would be good for @rektdeckard to confirm that this is only used as an example and is not deployed as is somewhere |
Contributor
|
@lukasIO this is indeed only used as an example, the Sandbox token server is internal to |
rektdeckard
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the TokenSource change, update the token server example to accept a request / receive a response that matches the standard that has been discussed as part of that change.
Namely, a few important details:
snake_casenotcamelCase- since this is an example, I made a breaking api change to the endpoint response, which I am assuming is fine. Previously the endpoint was just returning a string token though (ie, no wrapper object to rename fields within) so I don't really see an alternative unfortunately.participant_identity/participant_metadata/participant_attributes/room_configrequest fieldsserver_url/participant_tokenfields to the response