This repository has been archived by the owner on Sep 21, 2020. It is now read-only.
Improve CI/CD #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use-case for codepipeline is more along the lines of complex deployment pipelines with multiple release stages. The major downside for our use-case: It doesn't handle dynamic branches, since it's tailored to release branches
skorfmann
commented
Feb 23, 2019
| Pattern: "PULL_REQUEST_CREATED,PULL_REQUEST_UPDATED", | ||
| Type: "EVENT" | ||
| }, | ||
| { Pattern: "136789", Type: "ACTOR_ACCOUNT_ID" } |
There was a problem hiding this comment.
@MikeBild before this change, everyone would have been able to execute the codebuild build and execute whatever they wanted with AWS full-access permissions (pretty much root) by opening a pull-request 🎉 💃
So for now, we'll have to whitelist users, since we can't tell in the build itself if it's an untrusted pull request (fork) or not
There was a problem hiding this comment.
Wow! Pretty Cool! 🚢 Can't wait to see it in action. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falling back to just CodeBuild since that's closer to what we're actually looking for. Right now it's not possible to limit the Github triggers to branches with the CDK - see aws/aws-cdk#1842
However, it'd be possible in the AWS console