Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I refuse to entertain the idea that this PR broke typing 😠 |
CodSpeed Performance ReportMerging #309 will improve performances by ×3.6Comparing Summary
Benchmarks breakdown
|
|
Actually, for the typing failure one of the error comes from my trackmate loader. Should I make a commit to try to fix this? |
I think the errors coming from the This was a recent change where |
^ opened and issue python/typeshed#14616 |
yfukai
left a comment
There was a problem hiding this comment.
I updated my affiliation!
Co-authored-by: Yohsuke T. Fukai <ysk@yfukai.net>
msschwartz21
left a comment
There was a problem hiding this comment.
@DragaDoncila I was wondering if we should also add the java contributors here and then add the same file to the geff-java repo. Thoughts?
|
For Janelians, I wonder if we should mention the Howard Hughes Medical Institute as part of the affiliation. |
@msschwartz21 yep, agreed. I'll take a look at that |
@mkitti that's up to you all! I wasn't sure what the "official" affiliation was |
|
@DragaDoncila: @ilan-theodoro is missing 🥺 |
mkitti
left a comment
There was a problem hiding this comment.
We probably should acknowledge uncle Howard.
Ooops my bad, I did this manually so I'm not surprised I missed one. Thanks for catching, will fix! Or @ilan-theodoro just add yourself if you'd like |
Co-authored-by: Mark Kittisopikul <mkitti@users.noreply.github.com>
msschwartz21
left a comment
There was a problem hiding this comment.
Everyone has approved so we can go ahead and merge this. Thanks for organizing @DragaDoncila!
Proposed Change
As per zulip discussion, this PR adds a CITATION.cff file listing all current contributors, their affiliations, their ORCIDs and their GitHub usernames. I have listed contributors in the order they appeared on the contributors page, because it was easy for me. Please feel free to rearrange at will. Probs should be alphabetical? Once everyone confirms their details, we can do that. I did not include copilot, pre-commit bot or dependabot, though we are of course very grateful for their contributions.
It also lists a title and the GEFF license. I did not list a GEFF version because otherwise we'd have to keep updating it. We may want to include latest release version and add step that opens a PR to the release action. I'm not sure what other fields of the citation file we may want to include - potentiall a DOI once/if we set one up on zenodo.
I've done my best to spell everything correctly and include correct affiliations and orcids, but I will ping folks individually to check their own details before we merge.