[scripts] Introduce scripts/fetch-toolchains.py #418
Conversation
|
What do you think of updating CI to use this as well? |
joshuaseaton
force-pushed
the
toolchain
branch
2 times, most recently
from
e6b575a
to
7b18ccf
Compare
I'd like to nak that, because the CI explicitly pulls down what versions it needs, and only exactly what it needs for a specific build. Also it uses the github cache action which saves it from pulling more than once for any given roll. |
|
Fair enough! The needs for CI are certainly different than for devs (e.g., around caching). (This was the classic tension on Fuchsia around sentiments and filed bugs that would amount to "can't you just use fx in automation??") |
|
Looks like there's a problem, at least with --list, where it's finding the highest single digit one (ie, 8.2.0, etc) instead of a double digit (ie, 14) |
joshuaseaton
force-pushed
the
toolchain
branch
from
7b18ccf
to
1e72e7b
Compare
|
Ah, thanks for catching that. I was doing a naive strcmp on the version string, rather than a lexicographic comp on the actual int tokens. Fixed |
This change introduces $LK_ROOT/toolchain as an official installation directory for toolchains, as well as a new script for conveniently installing them there (versus manual GETs + untarring). getting_started.md is updated to suggest its use.
joshuaseaton
force-pushed
the
toolchain
branch
from
1e72e7b
to
32fe9a3
Compare
This change introduces $LK_ROOT/toolchains as an official installation directory for toolchains, as well as a new script for conveniently installing them there. getting_started.md is updated to suggest its use.