Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-ci] Add uefi_load unittest to github CI #411

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zhangxp1998
Copy link
Contributor

No description provided.

@travisg
Copy link
Member

travisg commented Jun 24, 2024

Looks pretty good, two tweaks:
a) see the file rename comment
b) can you prefix the commit with a [] based topic? in this case would probably be something like [github-ci]. See commits for inspiration.

Thanks!

unittest.py Outdated
@@ -0,0 +1,85 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this file into scripts/? Usually that's where things like this go, unless it's specific to an application or platform.

@zhangxp1998 zhangxp1998 changed the title Add uefi_load unittest to github CI [github-ci] Add uefi_load unittest to github CI Jun 24, 2024
@zhangxp1998 zhangxp1998 merged commit 87b7245 into littlekernel:master Jun 24, 2024
193 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants