F4 lcd #336
Open
F4 lcd #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with #338 for now didn't bring up gfx stuff just run memtest and got changing colors on screen. |
travisg
requested changes
Jul 23, 2022
| @@ -0,0 +1,78 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Can you add a short license header here?
| /** | ||
| * @brief LCD Control pin | ||
| */ | ||
| #define LCD_NCS_PIN GPIO_Pin_2 |
There was a problem hiding this comment.
Should there be some #includes up at the top of this file to make sure these are already defined?
| @@ -0,0 +1,682 @@ | |||
| /* | |||
There was a problem hiding this comment.
As before, can you double check that the line endings are unix and the +x bit is not set?
|
Okay I merged and pushed the library this is built on. Can you rebase and do a pass over the comments above? |
|
Sure, will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
This commit implements driver for ILI9341 found on stm32f429-DISCO1.
It is based on stm32 original driver and f7 eval driver from lk, both are mentioned in source file.
It is tested and seems to init display as excepted.
It is not fully working, as sdram is not yet up with lk on this board so i cant test layers and framebuffer.
Somr functionality of original st driver was removed, such as: second layer, drawing simple shapes, drawing bitmaps as ibelive those must be implemented on lk side, right?