Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up PL011 duplication #272

Open
cleverca22 opened this issue Oct 11, 2020 · 1 comment
Open

clean up PL011 duplication #272

cleverca22 opened this issue Oct 11, 2020 · 1 comment
Labels
refactor

Comments

@cleverca22
Copy link
Contributor

cleverca22 commented Oct 11, 2020 •
edited
Loading

merge platform/qemu-virt-arm/uart.c and platform/bcm28xx/uart.c into a single dev/pl011/uart.c driver
@cleverca22 cleverca22 changed the title clean up PL011 duplicating clean up PL011 duplication Oct 11, 2020
@cleverca22 cleverca22 removed their assignment Oct 11, 2020
@travisg
Copy link
Member

travisg commented Oct 11, 2020

Yah good idea. There might even be a third one.

A similar uart that's duplicated a few times is 8250 serial stuff.

cleverca22 added a commit to librerpi/lk that referenced this issue Oct 11, 2020
@cleverca22
[dev][pl011] fix issue littlekernel#272
b8faa4d
cleverca22 added a commit to librerpi/lk that referenced this issue Oct 11, 2020
@cleverca22
[dev][pl011] fix issue littlekernel#272
2c6d06b
cleverca22 added a commit to librerpi/lk that referenced this issue Oct 11, 2020
@cleverca22
[dev][pl011] fix issue littlekernel#272
a9568b7
cleverca22 added a commit to librerpi/lk that referenced this issue Oct 12, 2020
@cleverca22
[dev][uart][pl011] Move to common driver
eead957 
merges the qemu and bcm28xx versions of the uart driver together
fixed a bug that was present in the qemu version, that only reveals itself on real hw
increase the fifo level interrupt to 7/8 to get more bytes/irq under high load

fixes issue littlekernel#272
cleverca22 added a commit to librerpi/lk that referenced this issue Oct 12, 2020
@cleverca22
[dev][uart][pl011] Move to common driver
59de871 
merges the qemu and bcm28xx versions of the uart driver together
fixed a bug that was present in the qemu version, that only reveals itself on real hw
increase the fifo level interrupt to 7/8 to get more bytes/irq under high load

fixes issue littlekernel#272
cleverca22 added a commit to librerpi/lk that referenced this issue Oct 12, 2020
@cleverca22
[dev][uart][pl011] Move to common driver
31def0c 
merges the qemu and bcm28xx versions of the uart driver together
fixed a bug that was present in the qemu version, that only reveals itself on real hw
increase the fifo level interrupt to 7/8 to get more bytes/irq under high load

fix bug littlekernel#272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travisg @cleverca22