-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encode response content object returned from an exception handler. #3585
Merged
provinzkraut
merged 1 commit into
litestar-org:main
from
rafalkrupinski:fix/encode-exception-content
Jun 20, 2024
Merged
fix: encode response content object returned from an exception handler. #3585
provinzkraut
merged 1 commit into
litestar-org:main
from
rafalkrupinski:fix/encode-exception-content
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 328 328
Lines 14868 14870 +2
Branches 2366 2366
=======================================
+ Hits 14609 14611 +2
Misses 117 117
Partials 142 142 ☔ View full report in Codecov by Sentry. |
provinzkraut
requested changes
Jun 20, 2024
Thanks @rafalkrupinski! I've left one suggestion |
00e6612
to
a867ad5
Compare
provinzkraut
approved these changes
Jun 20, 2024
a867ad5
to
39606b8
Compare
Thanks for merging! Can't wait for the release ;) |
provinzkraut
pushed a commit
that referenced
this pull request
Jun 21, 2024
…r. (#3585) fix: encode response content object returned from a exception handler. Co-authored-by: Raphael Krupinski <[email protected]> (cherry picked from commit 883ca0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an handler raises an exception and exception handler returns a Response with a model (e.g. pydantic) object, encode that object with the app type_encoders.