-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OpenAPI): Correctly handle typing.NewType
#3580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 328 328
Lines 14856 14868 +12
Branches 2363 2366 +3
=======================================
+ Hits 14599 14611 +12
Misses 116 116
Partials 141 141 ☔ View full report in Codecov by Sentry. |
9d7f376
to
2738675
Compare
053aa17
to
e7711db
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3580 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry this took so long.
* Unwrap NewType for OpenAPI schema * Support nested NewType (cherry picked from commit 2e4b820)
When encountering a
typing.NewType
during OpenAPI schema generation, we currently treat it as an opaque type. This PR changes the behaviour such thattyping.NewType
s are always unwrapped during schema generation.