fix(OpenAPI): Correctly handle typing.NewType
#3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/private-api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 328 328
Lines 14856 14868 +12
Branches 2363 2366 +3
=======================================
+ Hits 14599 14611 +12
Misses 116 116
Partials 141 141 ☔ View full report in Codecov by Sentry. |
provinzkraut
force-pushed
the
fix-openapi-newtype
branch
from
9d7f376
to
2738675
Compare
provinzkraut
force-pushed
the
fix-openapi-newtype
branch
from
053aa17
to
e7711db
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3580 |
JacobCoffee
approved these changes
Jun 20, 2024
provinzkraut
added a commit
that referenced
this pull request
Jun 21, 2024
* Unwrap NewType for OpenAPI schema * Support nested NewType (cherry picked from commit 2e4b820)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering a
typing.NewTypeduring OpenAPI schema generation, we currently treat it as an opaque type. This PR changes the behaviour such thattyping.NewTypes are always unwrapped during schema generation.