fix: OpenAPI router and controller on same app. #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a case where two different handlers with the same name would be registered on an app that explicitly registers an OpenAPIController on the application, and implicitly uses the OpenAPI router via the OpenAPIConfig object. Closes #3337
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 323 323
Lines 14759 14761 +2
Branches 2342 2342
=======================================
+ Hits 14505 14507 +2
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3338 |
provinzkraut
approved these changes
Apr 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an
ImproperlyConfiguredExceptionwhere an app that explicitly registers anOpenAPIControlleron the application, and implicitly uses the OpenAPI router via theOpenAPIConfigobject. This was caused by the two different handlers being given the same name as defined inlitestar.constants.PR adds a distinct name for use by the handler that serves
openapi.jsonon the controller.Closes #3337
Description
Closes