-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use memoized request_class
and response_class
values
#3205
feat: Use memoized request_class
and response_class
values
#3205
Conversation
94e6c71
to
ee9d4ca
Compare
request_class
valuerequest_class
value
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3205 +/- ##
========================================
Coverage 98.23% 98.23%
========================================
Files 321 321
Lines 14482 14488 +6
Branches 2302 2304 +2
========================================
+ Hits 14227 14233 +6
Misses 113 113
Partials 142 142 ☔ View full report in Codecov by Sentry. |
e26b78d
to
a2856ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors add @kedod for code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do resolve_response_class()
at the same time? Its documented as being memoized just like this one, but isn't.
For interests sake, the memoization of That PR added However, it has since always been documented as being cached, even though it isn't, and we offer it as public API, so if users are calling it more than once they'd benefit from the caching as documented and it wouldn't really cost us anything. So, now that we are caching In that PR we also removed caching for |
@peterschutt I discovered exactly the same thing last evening and removed the changes for the |
8c3a6a4
to
c4db439
Compare
request_class
valuerequest_class
and response_class
values
e5e2023
to
90a5ff5
Compare
353ebca
to
525cd4c
Compare
90a5ff5
to
2f9206e
Compare
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3205 |
Description
request_class
andresponse_class
valuesCloses