Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message where missing dependency name doesn't match install extra #2921

Merged
merged 4 commits into from
Jan 10, 2024
Merged

fix: message where missing dependency name doesn't match install extra #2921

merged 4 commits into from
Jan 10, 2024

Conversation

horo-fox
Copy link
Contributor

@horo-fox horo-fox commented Dec 21, 2023

PR adds a 3rd argument, extra: str | None = None to MissingDependencyException to handle case where Litestar's install extra is not named the same as the required package that the extra will install.

@horo-fox horo-fox requested review from a team as code owners December 21, 2023 03:24
@horo-fox horo-fox changed the title Fix faulty exception wording in case of missing jinja2 fix: reword exception in case of missing jinja2 Dec 21, 2023
@peterschutt
Copy link
Contributor

Looking at this test:

def test_missing_dependency_exception_differing_package_name() -> None:
exc = MissingDependencyException("some_package", "install_via_this")
expected = (
"Package 'some_package' is not installed but required. You can install it by running 'pip install "
"litestar[install_via_this]' to install litestar with the required extra or 'pip install install_via_this' to "
"install the package separately"
)
assert str(exc) == expected

... it appears that adding the additional extra=... argument doesn't offer any more than is already available to us (even if the naming of the install_package isn't totally obvious).

So I think this PR can simply be a 1-liner:

raise MissingDependencyException("jinja2", "jinja")

@horo-fox
Copy link
Contributor Author

Well, pip install jinja isn't the same as pip install jinja2, but the extra is named jinja. So the extra name doesn't match the install name, though I assume normally it does match. I guess an alternative to adding an extra=... would be to add a new jinja2 extra?

@peterschutt
Copy link
Contributor

peterschutt commented Dec 21, 2023

Well, pip install jinja isn't the same as pip install jinja2, but the extra is named jinja. So the extra name doesn't match the install name, though I assume normally it does match. I guess an alternative to adding an extra=... would be to add a new jinja2 extra?

I agree with the problem you have identified. I don't agree that we need to add the extra key - this seems to be exactly what install_package is intended for.

@peterschutt
Copy link
Contributor

Sorry - I see it now, b/c it also uses install_package in the pip install ... section - sorry you are correct.

@horo-fox
Copy link
Contributor Author

horo-fox commented Jan 9, 2024

Sorry about the delay! This should address everything.

@peterschutt peterschutt changed the title fix: reword exception in case of missing jinja2 fix: message where missing dependency name doesn't match install extra Jan 10, 2024
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2921

Copy link
Contributor

@peterschutt peterschutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterschutt peterschutt merged commit 06d153e into litestar-org:main Jan 10, 2024
21 checks passed
@peterschutt
Copy link
Contributor

@all-contributors add @horo-fox for bug

Copy link
Contributor

@peterschutt

I've put up a pull request to add @horo-fox! 🎉

@horo-fox horo-fox deleted the fix-faulty-exception-wording branch January 10, 2024 23:53
cofin pushed a commit that referenced this pull request Jan 11, 2024
#2921)

* Fix faulty exception wording

* Fix another spotted mismatch

* PR review

---------

Co-authored-by: Peter Schutt <[email protected]>
cofin added a commit that referenced this pull request Jan 13, 2024
* Bump version to 2.6.0

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: `structlog` plugin & bug fixes (#2943)

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: example app using structlog

* fix: updated structlog with request logging

* fix: lazy initialized structlog fix

* feat: add structlog plugin

* fix: adds `set_level` to all Logging configurations

* fix: check that the object has the `setLevel` method before calling

* feat: adds test for plugin

* fix: parameter naming for `set_level` abstract method

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: structlog detects tty by default

* chore: linting fixes

* fix: color code correction

* fix: adjusted color code to be more visible

* fix: additional config settings

* feat: enable pretty-print in TTY

* fix: apply rich configuration

* fix: updated formatting to align with other messages

* chore: trim whitespace

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: andrew do <[email protected]>
Co-authored-by: Jacob Coffee <[email protected]>

* feat: allow using custom `CompressionFacade` implementations (#2952)

* refactor: move the different compressions into their own implementations

* feat: check if encoding given by the facade is accepted

* Bump version to 2.6.0

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: allow use of custom CompressionFacade implementations

* feat: allow gzip to be used as fallback for any backend

* docs: clarify 'backend'

* test: rename test to a clearer name

* docs: add docstring for 'CompressionFacade.encoding'

* fix: explicitly specify facade type

* fix: only import BrotliCompression if backend is brotli

If the backend is not brotli, then the user may not have installed brotli which would result in an incorrect
MissingDependency exception.

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* docs: fix typo for dto-tutorial/01-simple-dto-exclude (#2959)

Update 01-simple-dto-exclude.rst

remove one extra `it`

* docs: add jrycw as a contributor for doc (#2961)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Cody Fincher <[email protected]>

* Bug: Litestar changing root logger by default
Fixes #2862

* test: Improve `litestar.concurrency` coverage (#2955)

* Improve concurrency.py coverage

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: guacs <[email protected]>

* fix: only set root logger if it has no handlers

* Bug: Litestar changing root logger by default
Fixes #2862

* docs: fix code block in docstring (#2965)

* fix code block in docstring of TestClient

* fix code block in docstring of AsyncTestClient

---------

Co-authored-by: Jacob Coffee <[email protected]>

* Bug: Litestar changing root logger by default
Fixes #2862

* fix: message where missing dependency name doesn't match install extra (#2921)

* Fix faulty exception wording

* Fix another spotted mismatch

* PR review

---------

Co-authored-by: Peter Schutt <[email protected]>

* docs: add horo-fox as a contributor for bug (#2975)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add wer153 as a contributor for doc (#2972)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Cody Fincher <[email protected]>

* fix: modify test case for picologging

* feat: remove all handlers before executing test case.

* feat: Add `reload-include` and `reload-exclude` from uvicorn to CLI (#2973)

* Add reload-include and reload-exclude feature

* Update documentation

* Fix tests, update documentation

* Bump version to 2.6.0

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: `structlog` plugin & bug fixes (#2943)

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: example app using structlog

* fix: updated structlog with request logging

* fix: lazy initialized structlog fix

* feat: add structlog plugin

* fix: adds `set_level` to all Logging configurations

* fix: check that the object has the `setLevel` method before calling

* feat: adds test for plugin

* fix: parameter naming for `set_level` abstract method

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(channels): Postgres backends (#2803)

* wip

Signed-off-by: Janek Nouvertné <[email protected]>

* some debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* use a separate connection to publish/listen

Signed-off-by: Janek Nouvertné <[email protected]>

* reintroduce flaky

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Add psycopg backend

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix backend issues

Signed-off-by: Janek Nouvertné <[email protected]>

* Undo test debugging changes

Signed-off-by: Janek Nouvertné <[email protected]>

* mark groups

Signed-off-by: Janek Nouvertné <[email protected]>

* Ensure channel names ar quoted

Signed-off-by: Janek Nouvertné <[email protected]>

* sleep debugging

Signed-off-by: Janek Nouvertné <[email protected]>

* update docs

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing test

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix docs link

Signed-off-by: Janek Nouvertné <[email protected]>

* Add missing listener test

Signed-off-by: Janek Nouvertné <[email protected]>

* Formatting

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix test typing

Signed-off-by: Janek Nouvertné <[email protected]>

* Fix some coverage issue

Signed-off-by: Janek Nouvertné <[email protected]>

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* test skip sourcery

Signed-off-by: Janek Nouvertné <[email protected]>

* test(channels): Improve channels testing (#2838)

* Improve channels testing

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* chore(typing): various pyright issues (#2897)

Fix various pyright issues

Signed-off-by: Janek Nouvertné <[email protected]>

* fix(channels): Trailing messages after unsubscribes (#2894)

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(cli): Add ``--schema`` and ``--exclude`` option to route CLI. (#2886)

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* add exclude and schema cli options to route.

* updates per linting, mypy, and etc.

* fix some more mypy stuff.

* fix issue with linting.

* add doc for route cli options.

* fix issue with python3.8 not liking dict type.

* Update docs/usage/cli.rst

* Update litestar/cli/_utils.py

* fix malformed docs table.

---------

Co-authored-by: Jacob Coffee <[email protected]>

* test(CLI): Fix xdist issue (#2931)

Fix test for xdist

Signed-off-by: Janek Nouvertné <[email protected]>

* feat(core): Replace `anyio.to_thread.run_sync` with native versions (#2937)

Replace anyio.to_thread.run_sync with native versions

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: structlog detects tty by default

* chore: linting fixes

* fix: color code correction

* fix: adjusted color code to be more visible

* fix: additional config settings

* feat: enable pretty-print in TTY

* fix: apply rich configuration

* fix: updated formatting to align with other messages

* chore: trim whitespace

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: andrew do <[email protected]>
Co-authored-by: Jacob Coffee <[email protected]>

* feat: allow using custom `CompressionFacade` implementations (#2952)

* refactor: move the different compressions into their own implementations

* feat: check if encoding given by the facade is accepted

* Bump version to 2.6.0

Signed-off-by: Janek Nouvertné <[email protected]>

* feat: allow use of custom CompressionFacade implementations

* feat: allow gzip to be used as fallback for any backend

* docs: clarify 'backend'

* test: rename test to a clearer name

* docs: add docstring for 'CompressionFacade.encoding'

* fix: explicitly specify facade type

* fix: only import BrotliCompression if backend is brotli

If the backend is not brotli, then the user may not have installed brotli which would result in an incorrect
MissingDependency exception.

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Cody Fincher <[email protected]>

* feat: Add `reload-include` and `reload-exclude` from uvicorn to CLI (#2973)

* Add reload-include and reload-exclude feature

* Update documentation

* Fix tests, update documentation

---------

Signed-off-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: Janek Nouvertné <[email protected]>
Co-authored-by: andrew do <[email protected]>
Co-authored-by: Jacob Coffee <[email protected]>
Co-authored-by: guacs <[email protected]>
Co-authored-by: Jerry Wu <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Kim Minki <[email protected]>
Co-authored-by: horo <[email protected]>
Co-authored-by: Peter Schutt <[email protected]>
Co-authored-by: FergusMok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants