Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P 1164 auto fund sign account when omni executor is running in #3231

Merged

Conversation

BillyWooo
Copy link
Collaborator

instead of original idea to auto fund sign account, here use keystore to store generated account.
some minor update about makefile, gitignore, etc.

Copy link

linear bot commented Jan 15, 2025

@BillyWooo BillyWooo self-assigned this Jan 15, 2025
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

maybe I don't quite get the goal of this PR - IIUC even with keystore, it's not guaranteed that the signer in the keystore is funded?

Makefile Outdated
@@ -104,12 +104,15 @@ fmt: fmt-cargo fmt-taplo fmt-ts
fmt-cargo:
@cd parachain && cargo fmt --all
@cd tee-worker && cargo fmt --all
@cd tee-worker/identity && cargo fmt --all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this line I think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right.

#[derive(Subcommand)]
pub enum Commands {
Run(RunArgs),
GenKey(GenKeyArgs),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does GenKey do exactly? It seems we don't need this command

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used for the first time execution to generate a signer account. Then user can fund that account. Then start over.

@BillyWooo
Copy link
Collaborator Author

it's not guaranteed that the signer in the keystore is funded

At the development phase, an "Alice" account is provided by default. So it's by default we assume it has funds inside. At the same time, we get rid of "development" feature. There is no different versions of code for "development" and "production".

Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, however it's not auto funding executor's account.

@BillyWooo
Copy link
Collaborator Author

Looks fine, however it's not auto funding executor's account.

Yeah, by default it's 'Alice'. It's supposed to be funded. In production mode, then it's some real account which should be funded with real asset. Can't make it auto here.

Co-authored-by: Francisco Silva <[email protected]>
Signed-off-by: BillyWooo <[email protected]>
@BillyWooo BillyWooo merged commit 0b9513d into dev Jan 23, 2025
20 checks passed
@BillyWooo BillyWooo deleted the p-1164-auto-fund-sign-account-when-omni-executor-is-running-in branch January 23, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants