-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P 1164 auto fund sign account when omni executor is running in #3231
P 1164 auto fund sign account when omni executor is running in #3231
Conversation
…d random generated signer in non-development mode.
…account-when-omni-executor-is-running-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
maybe I don't quite get the goal of this PR - IIUC even with keystore, it's not guaranteed that the signer in the keystore is funded?
Makefile
Outdated
@@ -104,12 +104,15 @@ fmt: fmt-cargo fmt-taplo fmt-ts | |||
fmt-cargo: | |||
@cd parachain && cargo fmt --all | |||
@cd tee-worker && cargo fmt --all | |||
@cd tee-worker/identity && cargo fmt --all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this line I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right.
#[derive(Subcommand)] | ||
pub enum Commands { | ||
Run(RunArgs), | ||
GenKey(GenKeyArgs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does GenKey
do exactly? It seems we don't need this command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used for the first time execution to generate a signer account. Then user can fund that account. Then start over.
At the development phase, an "Alice" account is provided by default. So it's by default we assume it has funds inside. At the same time, we get rid of "development" feature. There is no different versions of code for "development" and "production". |
…account-when-omni-executor-is-running-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, however it's not auto funding executor's account.
Yeah, by default it's 'Alice'. It's supposed to be funded. In production mode, then it's some real account which should be funded with real asset. Can't make it auto here. |
…tor-is-running-in
Co-authored-by: Francisco Silva <[email protected]> Signed-off-by: BillyWooo <[email protected]>
instead of original idea to auto fund sign account, here use keystore to store generated account.
some minor update about makefile, gitignore, etc.