Skip to content

Conversation

@Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Mar 16, 2023

resolves #1442

This PR:

  • caps the maximum number of identities in returned IDGraph at 20 (tested by unittest in IMT)
  • only returns IDGraph for verify_identity
  • prettier ts
  • replace context.substrate with context.api as it's more conventional and substrate is a bit ambiguous

TODO: real ts-tests for linking 20+ identities => mainly to see how large the IDGraph would be.

@Kailai-Wang Kailai-Wang self-assigned this Mar 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1478 (6a09b48) into dev (220f22b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #1478      +/-   ##
==========================================
- Coverage   19.03%   19.03%   -0.01%     
==========================================
  Files         269      269              
  Lines       12607    12608       +1     
==========================================
  Hits         2400     2400              
- Misses      10207    10208       +1     
Impacted Files Coverage Δ
pallets/identity-management/src/lib.rs 29.06% <0.00%> (ø)
tee-worker/app-libs/stf/src/trusted_call.rs 0.00% <0.00%> (ø)
...er/litentry/pallets/identity-management/src/lib.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI should pass.

@Kailai-Wang Kailai-Wang merged commit d8087ec into dev Mar 17, 2023
@Kailai-Wang Kailai-Wang deleted the 1442-idgraph-adjustment branch March 17, 2023 11:09
wangminqi added a commit that referenced this pull request Mar 19, 2023
* build_assertion error propagate to parachain (#1456)

* AssertionBuildFail: add more details

* handle errors in on_success method

* emit event when vc is non-exists

* remove event

* remove VCNotExist from Event

* Fix benchmarking pallet-teerex (#1460)

* remove tee-dev from node default feature

* only rococo has tee-dev

* remove sccache in docker

* missing RUN

* update Dockerfile

* sleep for 1 second before the event websocket reconnect(fix #1416) (#1462)

* debug: Sync of Moonbeam upstream debug (#1450)

* debug: change of test

* debug: fix benchmark

* Fix the panic from WeightInfo in CI (#1466)

* update comment

* update runner tag

* minor update, cleanup history data

* fix errors in teeracle

* [benchmarking bot] Auto commit generated weights files (#1465)

Co-authored-by: Kailai-Wang <[email protected]>

* using pallet weights

---------

Co-authored-by: BillyWooo <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kailai-Wang <[email protected]>

* build_assertion error case test (#1463)

* error verify

* batch call of identity

* batch call of vc

* format code

* delete useless code

* verify error identity

* create error identities

* delete useless code

* delete useless code

* add comment&delete useless code

* format code

* txs types

* step error vc

* catch dispatchError

* revoke error test

* requestVc error

* change assert log

* fix merge errors

* add checkFailReason

* check fail reason

* move nonce out loop

* format code

* change test flow(only use A1 trigger error event)

* format code

* IDGraph adjustment (#1478)

* only keep idgraph for verified event

* add get_id_graph_with_max_len

* add tee pallets unittests

* adjust idgraph and prettier

* use context.api for better naming

* remove empty lines

---------

Co-authored-by: Zhouhui Tian <[email protected]>
Co-authored-by: Kai <[email protected]>
Co-authored-by: Linfeng.Yuan <[email protected]>
Co-authored-by: BillyWooo <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kailai-Wang <[email protected]>
Co-authored-by: Verin1005 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What happens when an IDGraph bloats up?

3 participants