Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀[Release v1.0.0] Merge into Main #30

Merged
merged 31 commits into from
Mar 29, 2023
Merged

🚀[Release v1.0.0] Merge into Main #30

merged 31 commits into from
Mar 29, 2023

Conversation

kcw-grunt
Copy link

@kcw-grunt kcw-grunt commented Mar 28, 2023 •
edited
Loading

Hero merge

  • Adds fpRate (False Positive Rate)
  • Accepts fpRate for the BloomFilter to modulate the sync time for the user
  • User can balance privacy vs sync time
  • Last major update to the library

Test Process

  • Update the git submodule for litewallet-android
  • Verify litewallet-ios is not adversely unaffected
  • Update the git submodule for litewallet-ios
  • Verify litewallet-ios is not adversely unaffected

LiteBit and others added 30 commits September 27, 2017 11:21
@LiteBit
typo :)
895898d
@voisine
va_list include
4b9a180
@voisine
enable ipv6
226bf5e
@voisine
default to ipv6 and fallback to ipv4
ffef229
@voisine
fix ipv4 fallback
a71c6c6
@acorscadden
Increase MAX_FEE_PER_KB
86fcc15
@lvaccaro
Fix 0 change output
35513de
@voisine
sha3-256 and keccak-256
05ae3c2
@voisine
const keywords
9813ffa
@voisine
update tx ordering on confirmation
b8ead01
@voisine
Merge pull request #7 from LiteBit/patch-1
4b724a2 
typo :)
@voisine
Merge pull request #9 from lvaccaro/fix-zero-change-output
7929bb9 
Fix 0 change output
@voisine
compiler warnings
3bd4d72
@losh11
Litecoin: params
c7e1e35
@losh11
Litecoin: scrypt pow & max_proof_of_work
d32d2f1
@losh11
Litecoin: disable retarget check
52992bb
@losh11
Litecoin: add new checkpoint
692ddfa
@losh11
BIP39_CREATION_TIME -> LoafWallet release date
2eefb18
@losh11
update secp
10788f5
@mosadialiou
make sure to call balanceChanged callback whenever balance is updated
1373c27
@kcw-grunt
Merge pull request #13 from mosadialiou/barry/fix-balance0
3558733 
make sure to call balanceChanged callback whenever balance is updated
@mosadialiou
Change bitcoin-testnet with litecoin-testnet
4751194
@kcw-grunt
Merge pull request #14 from mosadialiou/fix-testnet
2ea83a2 
Fix litecoin testnet
@mosadialiou
bech32: update files
5571307
@mosadialiou
add missing files
175443e
@mosadialiou
add BRPeerManagerStandardPort method which returns the standard port …
0bb8fa5 
…used for chain params
@kcw-grunt
Merge pull request #16 from mosadialiou/bech32-android
e8fc2bc 
Bech32 support on Litewallet Android
@kcw-grunt
🦺Updated the checkpoints: Android branch (#24)
aef48df 
* Updated the checkpoints

* only 1 checkpoint added

* Added Testnet checkpoint
@kcw-grunt
added interface to set fpRate (#28)
d09cce2 
fpRate: false positive rate for the bloomfilter
@kcw-grunt
fixed the signature (#29)
63b18b8
@kcw-grunt kcw-grunt changed the title Release/v1.0.0 🚀[Release v1.0.0] Merge into Main Mar 28, 2023
@kcw-grunt kcw-grunt added this to the v1.0.0 milestone Mar 28, 2023
@kcw-grunt kcw-grunt marked this pull request as ready for review March 28, 2023 18:14
josikie
josikie approved these changes Mar 29, 2023
View reviewed changes
Copy link

@josikie josikie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Both changes on BRPeerManager.c and BRPeerManager.h. What is bloomFilter used for?

@kcw-grunt
Copy link
Author

Wow...thanks so much for the look @josikie
Really needed it. We are in panic mode.

The Bloom Filter in short is a way to send a bunch of potential addresses to a node so the node doesn't know which ones you care about. The more false positives we send to the node the less likely the node knows which addresses are actually mine.

In the extreme, I can just send the node just my addresses only which means the random litecoin node can track what addresses are mine and it puts a spotlight on me. So, there is no privacy for me as a Litewallet user.

What we are trying to do is let the Litewallet user make sync as quick as possible without telling every node "Hey look at all my addresses and all my Litecoin!"

Make sense @josikie ?

@kcw-grunt kcw-grunt merged commit 4d2d088 into main Mar 29, 2023
@josikie
Copy link

josikie commented Mar 29, 2023 •
edited
Loading

Thank you for the answer! @kcw-grunt That's make sense. Are the potential addresses a fake address?

@kcw-grunt
Copy link
Author

Thank you for the answer! @kcw-grunt That's make sense. Are the potential addresses a fake address?
Well they are valid ltc addresses. The idea, @josikie , is the node cannot distinguish between your address that you care about and other addresses

@josikie
Copy link

josikie commented Mar 30, 2023

Oh that's good! @kcw-grunt

@kcw-grunt kcw-grunt deleted the release/v1.0.0 branch April 6, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josikie josikie josikie approved these changes

@Iferencak Iferencak Awaiting requested review from Iferencak

@losh11 losh11 Awaiting requested review from losh11

@vsima vsima Awaiting requested review from vsima

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@kcw-grunt @josikie @LiteBit @voisine @acorscadden @lvaccaro @losh11 @mosadialiou