🦺[Tech Debt] Update the checkpoints #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
losh11
approved these changes
May 18, 2021
mosadialiou
suggested changes
May 18, 2021
| @@ -83,7 +83,8 @@ static const BRCheckPoint BRMainNetCheckpoints[] = { | |||
| { 953568, uint256("e46e01cf1239cffa69408ac162d517bac5a4899972e0328fd0ba4d93e8ad3764"), 1457542869, 0x1b013c91 }, | |||
| { 1058400, uint256("76ce37c66d449a4ffbfc35674cf932da701066a001dc223754f9250dd2bdbc62"), 1473296285, 0x1b013ca7 }, | |||
| { 1260000, uint256("85a22b528d805bf7a641d1d7c6d96ef5054beda3dcab6be7b83f2e3df24b33a8"), 1502976600, 0x1a25a0d3 }, | |||
| { 1411200, uint256("92c85b76f3d4bffca76b23717e4eb1b667c77c96fd52d4dd5dd843bbee64cd73"), 1524838967, 0x1a0203a7 } | |||
| { 1411200, uint256("92c85b76f3d4bffca76b23717e4eb1b667c77c96fd52d4dd5dd843bbee64cd73"), 1524838967, 0x1a0203a7 }, | |||
| { 2036160, uint256("97ab7a0bf3cd7d694c1b369090aea9449e93f92763808de2a073cc8ab0657292"), 1618643881, 0x1a01ab48 } | |||
There was a problem hiding this comment.
@kcw-grunt Looks good. However there is an extra space issue. Please remove it.
There was a problem hiding this comment.
@kcw-grunt Here is the whole file
loafwallet-core/BRChainParams.h
Line 87 in f3ab6c8
It's not well formatted
kcw-grunt
requested review from
losh11,
JCHeist,
RyanPetter and
vsima
and removed request for
coblee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The current checkpoint is quite old
last blockheight: 1411200=April 18, 2018. The effect is full syncs take longer time.Approach
https://chainz.cryptoid.info/ltc/search.dwsSample
{ 1431360, uint256("a5480373ece83decc592f331c599cac73576be9666fae9cb5f75370be8082e5a"), 1527797819, 0x1a019af8},