- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NSInternalInconsistencyException & Swift runtime failure: arithmetic overflow #267
Merged
+131
−66
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
55b27c5
Fixed NSInternalInconsistencyException
azisramdhan 389d3dd
Handle Swift runtime failure: arithmetic overflow
azisramdhan 567a795
Enhance documentation for safe addition and subtraction methods
azisramdhan f3a701f
Reformat code using Xcode's indentation
azisramdhan d8fe99f
Refactor fee and transaction amount calculations to ensure safety and…
azisramdhan 8b559a1
Refactor defaultCurrencyCode didSet logic into helper function
azisramdhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reformat code using Xcode's indentation
- Applied consistent indentation using Xcode's Ctrl + I shortcut to improve code readability. - No functional changes were made.
commit f3a701fa60644be928f3a6ef8717496e087a695a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While comments like
// Safely calculate fee = fee + opsAmount
provide context, they are overly verbose and repeat what the code already expresses.For example;
// Ensure the new fee calculation doesn't overflow