Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️[Feature] Add remote config [deconflicted] #265

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

kcw-grunt
Copy link
Contributor

@kcw-grunt kcw-grunt commented Dec 17, 2024

Overview

Added the Firebase Remote Config to manage runtime

Deconfilcted: Needed to do some conflict resolution. Otherwise is the same as the previous remote config PR which was closed

Description

Using the current implementation from Android.

Updates

  • Added Firebase Remote Config SDK
  • Added test keys
  • Confirmed operation
  • Added API Tests

- Testing  FB client
- Confirmed Firebase registered for remote config
- Checking all params

Signed-off-by: kcw-grunt <[email protected]>
Readd Remote

Signed-off-by: kcw-grunt <[email protected]>
Signed-off-by: kcw-grunt <[email protected]>
@kcw-grunt kcw-grunt changed the title Feature/add remote config deconflicted ⚡️[Feature] Add remote config ~deconflicted~ Dec 17, 2024
@kcw-grunt kcw-grunt changed the title ⚡️[Feature] Add remote config ~deconflicted~ ⚡️[Feature] Add remote config _deconflicted_ Dec 17, 2024
@kcw-grunt kcw-grunt changed the title ⚡️[Feature] Add remote config _deconflicted_ ⚡️[Feature] Add remote config __deconflicted__ Dec 17, 2024
@kcw-grunt kcw-grunt changed the title ⚡️[Feature] Add remote config __deconflicted__ ⚡️[Feature] Add remote config [deconflicted] Dec 17, 2024
version bump

- Clean unused code
- Readded test class

Signed-off-by: kcw-grunt <[email protected]>
@kcw-grunt kcw-grunt force-pushed the feature/add-remote-config-deconflicted branch from 06e363e to 65d21ab Compare December 17, 2024 17:27
@kcw-grunt kcw-grunt self-assigned this Dec 17, 2024
@kcw-grunt kcw-grunt added the 🥳 feature New feature or enhancement request label Dec 17, 2024
@kcw-grunt kcw-grunt added this to the v3.14.X milestone Dec 17, 2024
@kcw-grunt kcw-grunt marked this pull request as ready for review December 17, 2024 17:29
Copy link
Contributor

@hassanashraf92 hassanashraf92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 👏

Copy link

@josikie josikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you! @kcw-grunt

@kcw-grunt kcw-grunt merged commit 2817dee into develop Dec 18, 2024
@kcw-grunt kcw-grunt deleted the feature/add-remote-config-deconflicted branch December 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳 feature New feature or enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants