-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️[Feature] Add remote config [deconflicted] #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Testing FB client - Confirmed Firebase registered for remote config - Checking all params Signed-off-by: kcw-grunt <[email protected]>
Readd Remote Signed-off-by: kcw-grunt <[email protected]>
Signed-off-by: kcw-grunt <[email protected]>
kcw-grunt
changed the title
Feature/add remote config deconflicted
⚡️[Feature] Add remote config ~deconflicted~
Dec 17, 2024
kcw-grunt
changed the title
⚡️[Feature] Add remote config ~deconflicted~
⚡️[Feature] Add remote config _deconflicted_
Dec 17, 2024
kcw-grunt
changed the title
⚡️[Feature] Add remote config _deconflicted_
⚡️[Feature] Add remote config __deconflicted__
Dec 17, 2024
kcw-grunt
changed the title
⚡️[Feature] Add remote config __deconflicted__
⚡️[Feature] Add remote config [deconflicted]
Dec 17, 2024
version bump - Clean unused code - Readded test class Signed-off-by: kcw-grunt <[email protected]>
kcw-grunt
force-pushed
the
feature/add-remote-config-deconflicted
branch
from
December 17, 2024 17:27
06e363e
to
65d21ab
Compare
hassanashraf92
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job 👏
azisramdhan
approved these changes
Dec 17, 2024
josikie
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thank you! @kcw-grunt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added the Firebase Remote Config to manage runtime
Deconfilcted: Needed to do some conflict resolution. Otherwise is the same as the previous remote config PR which was closed
Description
Using the current implementation from Android.
Updates