fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeedPhrase

[andhikayuana]

Whats Changed?

from the crashlytics all of source crash came from FragmentBalanceSeedReminder.fetchSeedPhrase that will call BRKeyStore.getPhrase(this.activity, 0), for now we just wrap with runCatching from Kotlin or you can call it try-catch, more detail

[kcw-grunt]

LTGM....lets see it this squashes the bug @andhikayuana

[josikie]

That's good. I read that runCatching will throw some information when it's unsucessfull. When you ran it, did you get any error info from it?

[andhikayuana]

That's good. I read that runCatching will throw some information when it's unsucessfull. When you ran it, did you get any error info from it?

do you mean you want to catch the error then send to the analytics? you can add .onFailure, check this out about the sample code

[josikie]

@andhikayuana thank you for the source, that's a very good idea.

I mean when you ran the code and you tried it, did it throw some information? Maybe you tried to log it. I read from the first source you gave, run catching will throw the error if the operation is fail.

[kcw-grunt]

@andhikayuana thank you for the source, that's a very good idea.

I mean when you ran the code and you tried it, did it throw some information? Maybe you tried to log it. I read from the first source you gave, run catching will throw the error if the operation is fail.

The problem with Java and Obj-C (@josikie) is the memory management is all manual and the try catch is the better way to understand. My understanding is the @andhikayuana solutions are when failing then. We'll see !