Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] update algolia version and send clicks #1398

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

e111077
Copy link
Collaborator

@e111077 e111077 commented Feb 7, 2025

Updated algolia search version, and introduced search-insights for anonymized click analytics. Specifically does not use cookies and does not store any identifiable data. Reason for introduction is because I realized I am only updating our site based on searches with no results, but not searches with no clicks.

This causes the problem that we had results for componentDidMount which linked to this page https://lit.dev/docs/frameworks/react/#how-it-works which is a bad result. Something like that could have been caught with click data.

Updated algolia search version, and introduced search-insights for anonymized click analytics. Specifically does not use cookies and does not store any identifiable data. Reason for introduction is because I realized I am only updating our site based on searches with no results, but not searches with no clicks.

This causes the problem that we had results for `componentDidMount` which linked to this page https://lit.dev/docs/frameworks/react/#how-it-works which is a bad result. Something like that could have been caught with click data.
Copy link

github-actions bot commented Feb 7, 2025

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1398-451c8f0---lit-dev-5ftespv5na-uc.a.run.app/

@e111077 e111077 marked this pull request as ready for review February 7, 2025 07:28
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like existing search hasn't broken and i see click event from search result getting sent.

@e111077 e111077 merged commit cc118dd into main Feb 9, 2025
15 checks passed
@e111077 e111077 deleted the algolia-clicks branch February 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants