Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlight colors! #1356

Merged
merged 2 commits into from
Jul 19, 2024
Merged

feat: add highlight colors! #1356

merged 2 commits into from
Jul 19, 2024

Conversation

e111077
Copy link
Collaborator

@e111077 e111077 commented Jul 19, 2024

shamelessly stolen from angular docs site

Yea or nay?!?!?!? It doesn't penetrate shadow roots

Copy link

github-actions bot commented Jul 19, 2024

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1356-37cb889---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1356-a0fb47e---lit-dev-5ftespv5na-uc.a.run.app/

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I really like it. The different colors at different orders is a nice touch. The only downside is I can't tell if leading or trailing whitespaces are selected or not but who cares!

@e111077 e111077 marked this pull request as ready for review July 19, 2024 23:18
@e111077 e111077 merged commit 32e0411 into main Jul 19, 2024
14 checks passed
@e111077 e111077 deleted the highlight-colors branch July 19, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants