Add Closure lint #93
Closed
Add Closure lint #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @TimvdLippe. I was unable to get Thoughts on what I might be doing wrong? |
|
You first have to build the project. E.g. `npm run build`
…On Mon, 11 Jun 2018, 13:58 Jon Cass, ***@***.***> wrote:
Thanks for working on this @TimvdLippe <https://github.com/TimvdLippe>. I
was unable to get npm run lint to execute on the closure-lint branch. I
get:
/dev/playground/lit-element$ npm run lint
> @***@***.*** lint /dev/playground/lit-element
> tslint --project ./ && gulp closure
No valid rules have been specified for TypeScript files
[07:53:53] Using gulpfile ~/dev/playground/lit-element/gulpfile.js
[07:53:53] Starting 'closure'...
[07:53:53] 'closure' errored after 11 ms
[07:53:53] Error: File not found with singular glob: /dev/playground/lit-element/lit-element.js
at Glob.<anonymous> (/dev/playground/lit-element/node_modules/glob-stream/index.js:41:11)
at Object.onceWrapper (events.js:315:30)
at emitOne (events.js:116:13)
at Glob.emit (events.js:211:7)
at Glob._finish (/dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:172:8)
at done (/dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:159:12)
at Glob._processSimple2 (/dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:652:12)
at /dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:640:10
at Glob._stat2 (/dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:736:12)
at lstatcb_ (/dev/playground/lit-element/node_modules/glob-stream/node_modules/glob/glob.js:728:12)
Thoughts on what I might be doing wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFrDb0DkHvgif7Tlpm6eZCmWh6T6Bq7Iks5t7ltjgaJpZM4UhvXM>
.
|
|
Got it, thanks. After running However, when I change the |
|
Ah okay interesting. Will take a look 👍 |
|
@joncass Per google/closure-compiler#1876 (comment) this appears to be a known limitation of the closure compiler. I am not sure what our options are in that case 😢 |
|
Yeah, I found google/closure-compiler#2650 which indicated similar. However it's more about mixins being awkward to use, rather than impossible. If you look at the code snippet from the start of the thread it looks like a combination of what I originally proposed in #78 and duplicating a few declarations might be a workaround? |
|
I am no longer pursuing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Closure linter to make sure Closure Compiler can work just fine on
lit-element. I was unable to reproduce the issues @joncass was encountering.Related to #80