-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Update fromAttribute complex type when value is not valid #888
fix Update fromAttribute complex type when value is not valid #888
Conversation
* catch error when json.parse value failed * return empty array or object when value isn't valid * Add test
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
src/lib/updating-element.ts
Outdated
return JSON.parse(value!); | ||
} catch (e) { | ||
// Ignore any previous errors. Only return a empty object | ||
return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be returning empty objects/arrays in this case. Downstream code would not be able to differentiate between an error value and an empty object. I think undefined
is a better fallback, even though it's still valid JSON.
Another option is to add an onError
property to PropertyDeclaration
and call it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onError property sounds good
Can i have an update about this contribution please @justinfagnani ? |
@justinfagnani Can you check my PR, please? thank you in advance |
Job is done in another commit. I close this PR. |
For better understanding on the issue please check #722
Following pull request #723. I added test and take in account return made.
This happens because JSON.parse('') will be fired when value is an invalid JSON.
So now it's return an empty array or empty object.
Reference Issue
Fixes #722